summaryrefslogtreecommitdiffstats
path: root/scene
diff options
context:
space:
mode:
authorRémi Verschelde <remi@verschelde.fr>2021-08-03 09:31:22 +0200
committerGitHub <noreply@github.com>2021-08-03 09:31:22 +0200
commit0f8cba285b2d71ded9e5e0fc5cdf6cc79b3eef55 (patch)
tree1fdf174e91b756028a9095c318afff1d6cf2af49 /scene
parenta1176ced4865ffb0e2b44b5e2f7cd6340d19666a (diff)
parente23f6a5bba79e995642610fd0e128b49414f5d9f (diff)
downloadredot-engine-0f8cba285b2d71ded9e5e0fc5cdf6cc79b3eef55.tar.gz
Merge pull request #50986 from raulsntos/fix-path-3d-end
Diffstat (limited to 'scene')
-rw-r--r--scene/3d/path_3d.cpp18
1 files changed, 15 insertions, 3 deletions
diff --git a/scene/3d/path_3d.cpp b/scene/3d/path_3d.cpp
index 6af2e7f879..490cf5fe67 100644
--- a/scene/3d/path_3d.cpp
+++ b/scene/3d/path_3d.cpp
@@ -100,11 +100,18 @@ void PathFollow3D::_update_transform(bool p_update_xyz_rot) {
}
float bi = c->get_bake_interval();
float o_next = offset + bi;
+ float o_prev = offset - bi;
if (loop) {
o_next = Math::fposmod(o_next, bl);
- } else if (rotation_mode == ROTATION_ORIENTED && o_next >= bl) {
- o_next = bl;
+ o_prev = Math::fposmod(o_prev, bl);
+ } else if (rotation_mode == ROTATION_ORIENTED) {
+ if (o_next >= bl) {
+ o_next = bl;
+ }
+ if (o_prev <= 0) {
+ o_prev = 0;
+ }
}
Vector3 pos = c->interpolate_baked(offset, cubic);
@@ -113,7 +120,12 @@ void PathFollow3D::_update_transform(bool p_update_xyz_rot) {
// will be replaced by "Vector3(h_offset, v_offset, 0)" where it was formerly used
if (rotation_mode == ROTATION_ORIENTED) {
- Vector3 forward = c->interpolate_baked(o_next, cubic) - pos;
+ Vector3 forward = c->interpolate_baked(o_next, cubic);
+
+ // Try with the previous position
+ if (forward.length_squared() < CMP_EPSILON2) {
+ forward = pos - c->interpolate_baked(o_prev, cubic);
+ }
if (forward.length_squared() < CMP_EPSILON2) {
forward = Vector3(0, 0, 1);