diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-07 09:04:44 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-07 09:04:44 +0200 |
| commit | e63252b4219680d109bfa41c24f483e97b37f40e (patch) | |
| tree | 8b8af6d7efcab9b2692d45dec65449fd83d2c8b9 /tests/scene/test_sprite_frames.h | |
| parent | 570220ba9b127325f1a5aa7bb17d5c6f76ccf62c (diff) | |
| parent | 955d5affa857ec1f358c56da8fb1ff4ab6590704 (diff) | |
| download | redot-engine-e63252b4219680d109bfa41c24f483e97b37f40e.tar.gz | |
Merge pull request #90705 from AThousandShips/foreach_list
Reduce and prevent unnecessary random-access to `List`
Diffstat (limited to 'tests/scene/test_sprite_frames.h')
| -rw-r--r-- | tests/scene/test_sprite_frames.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/scene/test_sprite_frames.h b/tests/scene/test_sprite_frames.h index bf127cd42c..55854b90e4 100644 --- a/tests/scene/test_sprite_frames.h +++ b/tests/scene/test_sprite_frames.h @@ -74,9 +74,10 @@ TEST_CASE("[SpriteFrames] Animation addition, list getter, renaming, removal, an sname_list.size() == test_names.size(), "StringName List getter returned list of expected size"); - for (int i = 0; i < test_names.size(); i++) { + int idx = 0; + for (List<StringName>::ConstIterator itr = sname_list.begin(); itr != sname_list.end(); ++itr, ++idx) { CHECK_MESSAGE( - sname_list[i] == StringName(test_names[i]), + *itr == StringName(test_names[idx]), "StringName List getter returned expected values"); } |