| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| |
| | |
Core: Fix `Callable.get_bound_arguments{,_count}()` return incorrect data
|
| | | |
|
| |\ \
| | |
| | |
| | | |
Core: Fix `Freed Object` booleanization
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | | |
Color: Expose OKHSL properties
|
| | | | | |
|
| | | | | |
|
| | |_|/
|/| |
| | |
| | |
| | | |
• `modernize-use-default-member-init` and `readability-redundant-member-init`
• Minor adjustments to `.clang-tidy` to improve syntax & remove redundancies
|
| |\ \ \
| | | |
| | | |
| | | | |
Always add decimal when converting float to string
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | | |
Allow using RID with `in` operator for Arrays and Dictionaries
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
|
| |/ / /
| | |
| | |
| | | |
`StringName` keys were sorted as `StringName` which is unstable.
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | | |
Fix RefCounted releasing early and not clearing reference
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Add missing CallableCustomMethodPointer for const methods
|
| | | | | | |
|
| |/ / / / |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | | |
Assign return value on `Variant` operator failure
|
| | | | |
| | | |
| | | |
| | | | |
Variant operators for String formatting and "in" could result in errors, which would return from validated_evaluate without assigning r_ret. This would cause scripts using the return value from these operators to get results from previously run code. Updated to return the original String value in the String formatting case, and false for "in" when an error occurs.
|
| | | | |
| | | |
| | | |
| | | | |
Added to `Object` and `Signal`
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Add callable support for `find` and `rfind` `Array` methods
|
| | |/ / / |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Fix `Dictionary.merge()` type validation
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Add metadata for `char16_t` and `char32_t`
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We don't seem to expose any API that uses `char16_t` yet, but I added it anyway since we make the type info for it.
I didn't add anything for `wchar_t` because we are not making a type info so maybe we don't have a need for it yet, it could be added in the future.
To prevent breaking compatibility with the C# bindings, we ignore the `char32_t` metadata and still use `System.Int64`.
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Implement typed dictionaries
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | | |
Add support for Transform2D/3D in `lerp()`
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Implements godotengine/godot-proposals#10579
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | | |
StringName Dictionary keys
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
also added 'is_string()' method to Variant
and refactored many String type comparisons to use it instead
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
binder_common: Fix uninitialized marshalling for `PtrToArg<char32_t>`
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
C# uses `long`s to access many native values. With `PtrToArg<m_enum>` and
`PtrToArg<bitfield<m_enum>>` this isn't a problem, as C++ code converts
through a `*(int64_t*)` cast in assignment, so all 64-bits are initialized.
However, with `PtrToArg<char32_t>`, value assignment happens through an
`*(int *)` cast, leaving 32 bits uninitialized where `int` is 32 bits. On
platforms where `int` is 16 bits, there are presumably 48 bits uninitialized,
though there are very few platforms where this is still the case.
The easiest way to see the practical effects of this is by looking at
`EventInputKey.Unicode`:
```csharp
public override void _Input(InputEvent @event) {
if (@event is InputEventKey keyEvent) {
if (keyEvent.IsPressed() && !keyEvent.Echo) {
var raw = keyEvent.Unicode;
var value = raw & 0xffffffff;
GD.Print($"Key pressed: raw: {raw}; masked: {(char) value} ({value})");
}
}
}
```
Pressing 'a' emits the following line:
```
Key pressed: raw: -3617008645356650399; masked: a (97)
```
Examining execution flow in gdb shows this conversion going through the
following line:
```
PtrToArg<char32_t>::encode (p_ptr=0x7ffcd5bb4b18, p_val=97 U'a') at ./core/variant/binder_common.h:221
221 *(int *)p_ptr = p_val;
```
Here, `p_val` is still 97, which is the value `InputEventKey.Unicode`
is expected to have. After assignment, `p *(int64_t *)0x7ffcd5bb4b18` displays
`-3617008645356650399`, with only the lower 32 bits being properly assigned,
and is the value we see from C#.
With this patch applied, the above testing `_Input` now prints:
```
Key pressed: raw: 97; masked: a (97)
```
Thank you to blujay1269 for asking about an unexpected value they saw in
`EventInputKey.Unicode`, which prompted this investigation.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Remove unused `initialize_ref`
|
| | | |_|/
| |/| | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Adds `is_valid_unicode_identifier()`
- Adds `is_valid_ascii_identifier()`
- Deprecates `is_valid_identifier()`
- Renames `validate_identifier()` to `validate_ascii_identifier()`
|
| | |/ /
|/| | |
|
| | | |
| | |
| | |
| | | |
Variant type was not updated correctly causing leaks in ref-counted
|
| |/ /
| |
| |
| | |
And fix a few occurrences of formatting errors that led me to this.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 150b50cfcde95f74419ade2811d963224e96fc98.
As discussed with the GDScript team, this has some implications which aren't
fully consensual yet, and which we want to revisit.
For now we revert to the 4.2 behavior for the 4.3 release, to avoid breaking
user expectations.
|
| |\ \
| | |
| | |
| | | |
[Core] Fix sharing of typed arrays from constructor
|
