summaryrefslogtreecommitdiffstats
path: root/core/io/resource_uid.cpp
diff options
context:
space:
mode:
authorThomas ten Cate <ttencate@gmail.com>2023-11-01 10:42:10 +0100
committerThomas ten Cate <ttencate@gmail.com>2023-11-01 11:14:13 +0100
commit2263d94cc3db989a16dc80c3b2480ab94f5a2aec (patch)
treee63afd2cab5c34f7323352c68ad256b806a24ea8 /core/io/resource_uid.cpp
parent6afd320984cf14198368cc6c53752813a02169e3 (diff)
downloadredot-engine-2263d94cc3db989a16dc80c3b2480ab94f5a2aec.tar.gz
Add comment why off-by-one error is hard to fix
See #83843 Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
Diffstat (limited to 'core/io/resource_uid.cpp')
-rw-r--r--core/io/resource_uid.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/core/io/resource_uid.cpp b/core/io/resource_uid.cpp
index 216fc24fff..edff3e1f14 100644
--- a/core/io/resource_uid.cpp
+++ b/core/io/resource_uid.cpp
@@ -35,6 +35,8 @@
#include "core/io/dir_access.h"
#include "core/io/file_access.h"
+// These constants are off by 1, causing the 'z' and '9' characters never to be used.
+// This cannot be fixed without breaking compatibility; see GH-83843.
static constexpr uint32_t char_count = ('z' - 'a');
static constexpr uint32_t base = char_count + ('9' - '0');