diff options
| author | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2024-04-15 15:18:34 +0200 |
|---|---|---|
| committer | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2024-05-04 16:08:55 +0200 |
| commit | 955d5affa857ec1f358c56da8fb1ff4ab6590704 (patch) | |
| tree | b667ac9f6f62bff17ce032683c0eb09727660555 /editor/plugins/mesh_library_editor_plugin.cpp | |
| parent | 7ebc866418b075df58cbe4e31fcf8b0c3acd70a1 (diff) | |
| download | redot-engine-955d5affa857ec1f358c56da8fb1ff4ab6590704.tar.gz | |
Reduce and prevent unnecessary random-access to `List`
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)
* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
Diffstat (limited to 'editor/plugins/mesh_library_editor_plugin.cpp')
| -rw-r--r-- | editor/plugins/mesh_library_editor_plugin.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/editor/plugins/mesh_library_editor_plugin.cpp b/editor/plugins/mesh_library_editor_plugin.cpp index 8bfd3d0957..1a5727a1e8 100644 --- a/editor/plugins/mesh_library_editor_plugin.cpp +++ b/editor/plugins/mesh_library_editor_plugin.cpp @@ -253,8 +253,8 @@ MeshLibraryEditor::MeshLibraryEditor() { ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions); file->clear_filters(); file->set_title(TTR("Import Scene")); - for (int i = 0; i < extensions.size(); i++) { - file->add_filter("*." + extensions[i], extensions[i].to_upper()); + for (const String &extension : extensions) { + file->add_filter("*." + extension, extension.to_upper()); } add_child(file); file->connect("file_selected", callable_mp(this, &MeshLibraryEditor::_import_scene_cbk)); |