summaryrefslogtreecommitdiffstats
path: root/modules/gdscript/gdscript_cache.cpp
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2024-10-04 11:22:14 +0200
committerRémi Verschelde <rverschelde@gmail.com>2024-10-04 11:22:14 +0200
commit32239d477be66d8c94e9a7a95c56ae0cbad54cfb (patch)
treea04036601d71f6e34fe1728a4c74e42da5113c4d /modules/gdscript/gdscript_cache.cpp
parentc28dd316a95444419444c3bd86d82a8233c0d6b1 (diff)
parent6286f9d21d4c7604ae0fd91e49896da79f0b78f7 (diff)
downloadredot-engine-32239d477be66d8c94e9a7a95c56ae0cbad54cfb.tar.gz
Merge pull request #97769 from dalexeev/gds-fix-gdscript-cache-path
GDScript: Fix `GDScriptCache::get_full_script()` uses non-remapped path
Diffstat (limited to 'modules/gdscript/gdscript_cache.cpp')
-rw-r--r--modules/gdscript/gdscript_cache.cpp12
1 files changed, 8 insertions, 4 deletions
diff --git a/modules/gdscript/gdscript_cache.cpp b/modules/gdscript/gdscript_cache.cpp
index b3c0744bdf..3c022412bd 100644
--- a/modules/gdscript/gdscript_cache.cpp
+++ b/modules/gdscript/gdscript_cache.cpp
@@ -297,6 +297,7 @@ Vector<uint8_t> GDScriptCache::get_binary_tokens(const String &p_path) {
Ref<GDScript> GDScriptCache::get_shallow_script(const String &p_path, Error &r_error, const String &p_owner) {
MutexLock lock(singleton->mutex);
+
if (!p_owner.is_empty()) {
singleton->dependencies[p_owner].insert(p_path);
}
@@ -307,7 +308,7 @@ Ref<GDScript> GDScriptCache::get_shallow_script(const String &p_path, Error &r_e
return singleton->shallow_gdscript_cache[p_path];
}
- String remapped_path = ResourceLoader::path_remap(p_path);
+ const String remapped_path = ResourceLoader::path_remap(p_path);
Ref<GDScript> script;
script.instantiate();
@@ -332,6 +333,7 @@ Ref<GDScript> GDScriptCache::get_shallow_script(const String &p_path, Error &r_e
}
singleton->shallow_gdscript_cache[p_path] = script;
+
return script;
}
@@ -359,16 +361,18 @@ Ref<GDScript> GDScriptCache::get_full_script(const String &p_path, Error &r_erro
}
}
+ const String remapped_path = ResourceLoader::path_remap(p_path);
+
if (p_update_from_disk) {
- if (p_path.get_extension().to_lower() == "gdc") {
- Vector<uint8_t> buffer = get_binary_tokens(p_path);
+ if (remapped_path.get_extension().to_lower() == "gdc") {
+ Vector<uint8_t> buffer = get_binary_tokens(remapped_path);
if (buffer.is_empty()) {
r_error = ERR_FILE_CANT_READ;
return script;
}
script->set_binary_tokens_source(buffer);
} else {
- r_error = script->load_source_code(p_path);
+ r_error = script->load_source_code(remapped_path);
if (r_error) {
return script;
}