diff options
| author | Guillaume Turri <g.turri@criteo.com> | 2024-07-28 10:24:09 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-09-04 18:07:49 +0200 |
| commit | ea9dff87ae29ea34cff8d0452c2ea799c16b2d0c (patch) | |
| tree | 7605f3c08e472b9da344958d4b17c17104c27298 /scene/3d | |
| parent | 139f9989e6afcc9376c1c3551cc410ce04981163 (diff) | |
| download | redot-engine-ea9dff87ae29ea34cff8d0452c2ea799c16b2d0c.tar.gz | |
Add error checks for bad configuration in `PathFollow2D/3D` `set_progress_ratio`
When a PathFollow is badly configured it's possible to have code that
call get_progress_ratio just after set_progress_ratio does not return
the value just set, which may be confusing for developer (ie that
myPathFollow2D.set_progress_ratio(0.5)
myPathFollow2D.get_progress_ratio()
does not return 0.5)
This commit makes ensures the developer has useful error messages in
such case, to make it easier to troubleshot it.
Diffstat (limited to 'scene/3d')
| -rw-r--r-- | scene/3d/path_3d.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/scene/3d/path_3d.cpp b/scene/3d/path_3d.cpp index 1f8f7cd54c..dc030b6a0f 100644 --- a/scene/3d/path_3d.cpp +++ b/scene/3d/path_3d.cpp @@ -461,9 +461,10 @@ real_t PathFollow3D::get_progress() const { } void PathFollow3D::set_progress_ratio(real_t p_ratio) { - if (path && path->get_curve().is_valid() && path->get_curve()->get_baked_length()) { - set_progress(p_ratio * path->get_curve()->get_baked_length()); - } + ERR_FAIL_NULL_MSG(path, "Can only set progress ratio on a PathFollow3D that is the child of a Path3D which is itself part of the scene tree."); + ERR_FAIL_COND_MSG(path->get_curve().is_null(), "Can't set progress ratio on a PathFollow3D that does not have a Curve."); + ERR_FAIL_COND_MSG(!path->get_curve()->get_baked_length(), "Can't set progress ratio on a PathFollow3D that has a 0 length curve."); + set_progress(p_ratio * path->get_curve()->get_baked_length()); } real_t PathFollow3D::get_progress_ratio() const { |