diff options
| author | Thaddeus Crews <repiteo@outlook.com> | 2024-11-22 14:54:30 -0600 |
|---|---|---|
| committer | Thaddeus Crews <repiteo@outlook.com> | 2024-11-22 14:54:30 -0600 |
| commit | 37305e40bcec774ad8d0948589f46f9f02be8c23 (patch) | |
| tree | e05a99a386eb4a6a0cac19b8f9bdff35951a0935 /scene/animation | |
| parent | dcb59f0e7efffa97570147817177188298c6b08b (diff) | |
| parent | 761a20f7a720864af1c43747f5ac31b9915d04e3 (diff) | |
| download | redot-engine-37305e40bcec774ad8d0948589f46f9f02be8c23.tar.gz | |
Merge pull request #95711 from TokageItLab/warn-oneshot-prop
Add hint for oneshot property & warning when it will be updated continuously by Force Continuous in `AnimationMixer`
Diffstat (limited to 'scene/animation')
| -rw-r--r-- | scene/animation/animation_mixer.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/scene/animation/animation_mixer.cpp b/scene/animation/animation_mixer.cpp index d4c8af4a4c..3e09e425b0 100644 --- a/scene/animation/animation_mixer.cpp +++ b/scene/animation/animation_mixer.cpp @@ -748,6 +748,15 @@ bool AnimationMixer::_update_caches() { } } + if (is_value && callback_mode_discrete == ANIMATION_CALLBACK_MODE_DISCRETE_FORCE_CONTINUOUS) { + if (child) { + PropertyInfo prop_info; + ClassDB::get_property_info(child->get_class_name(), path.get_concatenated_subnames(), &prop_info); + if (prop_info.hint == PROPERTY_HINT_ONESHOT) { + WARN_PRINT_ED(vformat("%s: '%s', Value Track: '%s' is oneshot property, but will be continuously updated. Consider setting a value other than ANIMATION_CALLBACK_MODE_DISCRETE_FORCE_CONTINUOUS to AnimationMixer.callback_mode_dominant.", mixer_name, String(E), String(path))); + } + } + } } break; case Animation::TYPE_POSITION_3D: case Animation::TYPE_ROTATION_3D: |