diff options
| author | lawnjelly <lawnjelly@gmail.com> | 2022-01-19 19:46:17 +0000 |
|---|---|---|
| committer | lawnjelly <lawnjelly@gmail.com> | 2022-01-20 13:07:49 +0000 |
| commit | b411a731fef9af1c0a73e4d5b718e5a6b12af1c2 (patch) | |
| tree | aae207a63b24f823efef9901e92b5222e2f3618b /scene/resources/immediate_mesh.cpp | |
| parent | 249c60e9d1aacd07d87786db8059f30aed02bb68 (diff) | |
| download | redot-engine-b411a731fef9af1c0a73e4d5b718e5a6b12af1c2.tar.gz | |
Add nodiscard to core math classes to catch c++ errors.
A common source of errors is to call functions (such as round()) expecting them to work in place, but them actually being designed only to return the processed value. Not using the return value in this case in indicative of a bug, and can be flagged as a warning by using the [[nodiscard]] attribute.
Diffstat (limited to 'scene/resources/immediate_mesh.cpp')
| -rw-r--r-- | scene/resources/immediate_mesh.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scene/resources/immediate_mesh.cpp b/scene/resources/immediate_mesh.cpp index b9469803a0..28afef8638 100644 --- a/scene/resources/immediate_mesh.cpp +++ b/scene/resources/immediate_mesh.cpp @@ -382,7 +382,7 @@ AABB ImmediateMesh::get_aabb() const { if (i == 0) { aabb = surfaces[i].aabb; } else { - aabb.merge(surfaces[i].aabb); + aabb = aabb.merge(surfaces[i].aabb); } } return aabb; |